Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system id for caloCellPosition [temporary, should refactor this] #429

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Fix system id for caloCellPosition [temporary, should refactor this] #429

merged 2 commits into from
Dec 3, 2020

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented Dec 1, 2020

Fix the system id in order to have meaningful positions for the ECAL barrel. This is a temporary fix, we should probably refactor this to avoid such a hard coding, possibly with another way to retrieve the system ID on the flight if it is possible. Or by having only one position tool here and by calling this algorithm once per sub-system in the config file.

@faltovaj
Copy link
Contributor

faltovaj commented Dec 2, 2020

Hi Brieuc,
at the moment the algorithm is in the directory RecFCChhCalorimeter and for FCChh reference detector all IDs are set correctly. That's why I would not change the values in the code in here. A temporary solution could be to make a copy of the algorithm with correct IDs for FCCee in RecFCCeeCalorimeter. We can make "Issue" to keep in mind this is something to be fixed. What do you think?
Cheers,
Jana

@BrieucF
Copy link
Contributor Author

BrieucF commented Dec 2, 2020

Hi Jana, good point, I will change that and create an issue!

@BrieucF
Copy link
Contributor Author

BrieucF commented Dec 2, 2020

Updated, see issue #430

@faltovaj
Copy link
Contributor

faltovaj commented Dec 3, 2020

Hi Brieuc,
thanks for the new version. I'm happy with that.
Cheers,
Jana

@vvolkl
Copy link
Member

vvolkl commented Dec 3, 2020

LGTM. Could you also add those changes to https://github.com/HEP-FCC/k4RecCalorimeter?

@vvolkl
Copy link
Member

vvolkl commented Dec 3, 2020

I recently updated the tests, will merge now and check the test results of the master branch.

@vvolkl vvolkl merged commit dcb9191 into HEP-FCC:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrieucF @faltovaj @vvolkl